minor: text error in cron report

  • bcraigie
  • Topic Author
  • Offline
  • New Member
  • New Member
More
5 months 5 days ago - 5 months 5 days ago #9222 by bcraigie
minor: text error in cron report was created by bcraigie
Hi.

In the file

administrator/components/com_securitycheckprocontrolcenter/library/cli/control_center_cli.php

at line 209, the text reading :

return "Control Center monitor: Site's contacted sucessfully!!";

should read :

return "Control Center monitor: Sites contacted successfully!!";


Plurals don't need an apostrophe, and spelling of successfully.   English is a curious language.

I would suggest removing the !! as well because, are you really surprised that the sites were contacted successfully?

But ideally, this should be in a language file so it can report in the correct language.

 
Last edit: 5 months 5 days ago by bcraigie.

Please Log in or Create an account to join the conversation.

More
5 months 5 days ago - 5 months 4 days ago #9223 by Jose
Replied by Jose on topic minor: text error in cron report
Hi bcraigie,

Thank you very much for reporting this! I will fix it in the next release.

I would suggest removing the !! as well because, are you really surprised that the sites were contacted successfully?

It's always a good notice that there are no errors ;) I will follow your suggestion anyway.

But ideally, this should be in a language file so it can report in the correct language.

I'm not sure if we can use language files in cli files. That's why I didn't use that feature.
EDITED: Next release will also use language files for reports in the correct language.

Regards,
Jose
Last edit: 5 months 4 days ago by Jose. Reason: Add some extra info

Please Log in or Create an account to join the conversation.

Time to create page: 0.221 seconds